react useEffect is running and fetching data none stop
I have a simple react component that uses react hooks. I'm using useEffect and useState.
The problem is that i realized my API is getting huge amount of hits, after debugging i see that useEffect is running none stop!
This is my very simple code:
function DisplayUser({userId}) {
const [loggedUser, setLoggedUser] = React.useState(null);
React.useEffect(() => {
fetchData(userId).then(user => {
setLoggedUser(user);
})
});
return (
<div>
<div>{loggedUser}</div>
</div>
);
}
javascript reactjs react-hooks
asked Nov 10 at 13:32
swing_js
615
add a comment |
I have a simple react component that uses react hooks. I'm using useEffect and useState.
The problem is that i realized my API is getting huge amount of hits, after debugging i see that useEffect is running none stop!
This is my very simple code:
function DisplayUser({userId}) {
const [loggedUser, setLoggedUser] = React.useState(null);
React.useEffect(() => {
fetchData(userId).then(user => {
setLoggedUser(user);
})
});
return (
<div>
<div>{loggedUser}</div>
</div>
);
}
javascript reactjs react-hooks
asked Nov 10 at 13:32
swing_js
615
add a comment |
I have a simple react component that uses react hooks. I'm using useEffect and useState.
The problem is that i realized my API is getting huge amount of hits, after debugging i see that useEffect is running none stop!
This is my very simple code:
function DisplayUser({userId}) {
const [loggedUser, setLoggedUser] = React.useState(null);
React.useEffect(() => {
fetchData(userId).then(user => {
setLoggedUser(user);
})
});
return (
<div>
<div>{loggedUser}</div>
</div>
);
}
javascript reactjs react-hooks
asked Nov 10 at 13:32
swing_js
615
I have a simple react component that uses react hooks. I'm using useEffect and useState.
The problem is that i realized my API is getting huge amount of hits, after debugging i see that useEffect is running none stop!
This is my very simple code:
function DisplayUser({userId}) {
const [loggedUser, setLoggedUser] = React.useState(null);
React.useEffect(() => {
fetchData(userId).then(user => {
setLoggedUser(user);
})
});
return (
<div>
<div>{loggedUser}</div>
</div>
);
}
javascript reactjs react-hooks
javascript reactjs react-hooks
asked Nov 10 at 13:32
swing_js
615
asked Nov 10 at 13:32
swing_js
615
asked Nov 10 at 13:32
swing_js
615
asked Nov 10 at 13:32
swing_js
615
asked Nov 10 at 13:32
swing_js
615
615
add a comment |
add a comment |
1 Answer
1
active
oldest
votes
Whats happening here is that useEffect is running after each render
Does useEffect run after every render? Yes! By default, it runs both after the first render and after every update...
There is a way to do Optimizing Performance by Skipping Effects, you can pass an array as a second argument.
If the array is empty, that means there are no "dependencies" for this effect and it will run only once (quite simillar to componentDidMount).
If the array has values, then the effect will re-run only when those values have changeded (simillar to what we do with componentDidUpdate).
So in your case it is wise to pass an array with the userId value because you'll want to re-run the effect and fetch the user data only when the userId has changed.
function DisplayUser({userId}) {
const [loggedUser, setLoggedUser] = React.useState(null);
React.useEffect(() => {
fetchData(userId).then(user => {
setLoggedUser(user);
})
}, [userId]); // only run when userId changed
return (
<div>
<div>{loggedUser}</div>
</div>
);
}
answered Nov 10 at 13:35
Sagiv b.g
15.8k21954
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53239470%2freact-useeffect-is-running-and-fetching-data-none-stop%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
Whats happening here is that useEffect is running after each render
Does useEffect run after every render? Yes! By default, it runs both after the first render and after every update...
There is a way to do Optimizing Performance by Skipping Effects, you can pass an array as a second argument.
If the array is empty, that means there are no "dependencies" for this effect and it will run only once (quite simillar to componentDidMount).
If the array has values, then the effect will re-run only when those values have changeded (simillar to what we do with componentDidUpdate).
So in your case it is wise to pass an array with the userId value because you'll want to re-run the effect and fetch the user data only when the userId has changed.
function DisplayUser({userId}) {
const [loggedUser, setLoggedUser] = React.useState(null);
React.useEffect(() => {
fetchData(userId).then(user => {
setLoggedUser(user);
})
}, [userId]); // only run when userId changed
return (
<div>
<div>{loggedUser}</div>
</div>
);
}
answered Nov 10 at 13:35
Sagiv b.g
15.8k21954
add a comment |
Whats happening here is that useEffect is running after each render
Does useEffect run after every render? Yes! By default, it runs both after the first render and after every update...
There is a way to do Optimizing Performance by Skipping Effects, you can pass an array as a second argument.
If the array is empty, that means there are no "dependencies" for this effect and it will run only once (quite simillar to componentDidMount).
If the array has values, then the effect will re-run only when those values have changeded (simillar to what we do with componentDidUpdate).
So in your case it is wise to pass an array with the userId value because you'll want to re-run the effect and fetch the user data only when the userId has changed.
function DisplayUser({userId}) {
const [loggedUser, setLoggedUser] = React.useState(null);
React.useEffect(() => {
fetchData(userId).then(user => {
setLoggedUser(user);
})
}, [userId]); // only run when userId changed
return (
<div>
<div>{loggedUser}</div>
</div>
);
}
answered Nov 10 at 13:35
Sagiv b.g
15.8k21954
add a comment |
Whats happening here is that useEffect is running after each render
Does useEffect run after every render? Yes! By default, it runs both after the first render and after every update...
There is a way to do Optimizing Performance by Skipping Effects, you can pass an array as a second argument.
If the array is empty, that means there are no "dependencies" for this effect and it will run only once (quite simillar to componentDidMount).
If the array has values, then the effect will re-run only when those values have changeded (simillar to what we do with componentDidUpdate).
So in your case it is wise to pass an array with the userId value because you'll want to re-run the effect and fetch the user data only when the userId has changed.
function DisplayUser({userId}) {
const [loggedUser, setLoggedUser] = React.useState(null);
React.useEffect(() => {
fetchData(userId).then(user => {
setLoggedUser(user);
})
}, [userId]); // only run when userId changed
return (
<div>
<div>{loggedUser}</div>
</div>
);
}
answered Nov 10 at 13:35
Sagiv b.g
15.8k21954
Whats happening here is that useEffect is running after each render
Does useEffect run after every render? Yes! By default, it runs both after the first render and after every update...
There is a way to do Optimizing Performance by Skipping Effects, you can pass an array as a second argument.
If the array is empty, that means there are no "dependencies" for this effect and it will run only once (quite simillar to componentDidMount).
If the array has values, then the effect will re-run only when those values have changeded (simillar to what we do with componentDidUpdate).
So in your case it is wise to pass an array with the userId value because you'll want to re-run the effect and fetch the user data only when the userId has changed.
function DisplayUser({userId}) {
const [loggedUser, setLoggedUser] = React.useState(null);
React.useEffect(() => {
fetchData(userId).then(user => {
setLoggedUser(user);
})
}, [userId]); // only run when userId changed
return (
<div>
<div>{loggedUser}</div>
</div>
);
}
answered Nov 10 at 13:35
Sagiv b.g
15.8k21954
answered Nov 10 at 13:35
Sagiv b.g
15.8k21954
answered Nov 10 at 13:35
Sagiv b.g
15.8k21954
answered Nov 10 at 13:35
Sagiv b.g
15.8k21954
15.8k21954
add a comment |
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53239470%2freact-useeffect-is-running-and-fetching-data-none-stop%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
